Skip to content

Conversation

@eclipse-platform-bot
Copy link
Contributor

@eclipse-platform-bot eclipse-platform-bot commented Jun 11, 2025

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Test Results

 1 893 files  ±0   1 893 suites  ±0   1h 26m 16s ⏱️ - 4m 7s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 0226ac4. ± Comparison against base commit a4b95da.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the clean-code/ua/org.eclipse.help.ui branch from 212c6db to 0226ac4 Compare June 14, 2025 18:38
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine, except for a variable name clash introduced by the cleanup in line 450 of ContextHelpPart. I have manually fixed the issue by adapting the used variable name and reported the behavior at JDT.UI:

@HeikoKlare HeikoKlare merged commit 955952c into master Jun 14, 2025
18 checks passed
@HeikoKlare HeikoKlare deleted the clean-code/ua/org.eclipse.help.ui branch June 14, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants